-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mach: Implement LC_NOTE
#342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, this is good stuff! Could you add the enum attribute that makes additions not a breaking change, and then since this is breaking, if it's ok I'd like to wait a bit and roll up other breaking changes.
on that note, it might be prudent to survey other enums in this library to add this attribute to so that we can start thinking about 1.0 release
let comm = bytes.pread_with::<NoteCommand>(0, le)?; | ||
Ok((Note(comm), size)) | ||
} | ||
_ => Ok((Unimplemented(lc), size)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think load commands are added very often, so maybe this should now become a bad lc command error in future PR?
Thanks for the review, added
Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great thanks so much!
NB for m4b: breaking change |
released in 0.7.0, thank you so much for your patience! |
No description provided.